Opened 16 years ago
Closed 16 years ago
#3871 closed Bug (fixed)
Undo resets Redo buffer when undoing to beginning
| Reported by: | Damian | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
| Component: | Core : Undo & Redo | Version: | |
| Keywords: | IBM Confirmed Review+ | Cc: |
Description
The redo buffer is reset when using the undo feature all the way to the beginning.
To reproduce:
- Open nightly Ajax sample
- Add some text on a few lines
- Use undo until reaching the initial state
- Attempt to redo last undo
Result: Redo is enabled but does not have any more state
Expected: Redo should maintain state and allow redoing even after reaching the end of the undo stack
Attachments (3)
Change History (11)
comment:1 Changed 16 years ago by
| Keywords: | Confirmed added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
comment:2 Changed 16 years ago by
| Keywords: | Review? added |
|---|
comment:3 Changed 16 years ago by
| Component: | General → Core : Undo/Redo |
|---|---|
| Priority: | Normal → High |
Changed 16 years ago by
| Attachment: | 3871.patch added |
|---|
comment:4 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|---|
| Summary: | [IE7] Undo resets Redo buffer when undoing to beginning → Undo resets Redo buffer when undoing to beginning |
comment:5 Changed 16 years ago by
| Keywords: | Review- added; Review+ removed |
|---|
- In the editingblock plugin, please fire the beforeModeUnload event at line 171. It may happen that the event is used to manipulate the data right before unloading it.
- Coding style: please make it correct and consistent with the rest of the code. Also, the change at line 95 is not needed.
Changed 16 years ago by
| Attachment: | 3871_2.patch added |
|---|
comment:6 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Changed 16 years ago by
| Attachment: | 3871_3.patch added |
|---|
comment:7 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Sometimes words are not enough to properly express your intentions. I've attached a new patch for it. Please go ahead committing it if it satisfy the ticket needs.
comment:8 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
The problem was due to incorrect snapshot saving logic which create one unreachable snapshot at the beginning of stack.