Opened 8 years ago
Closed 8 years ago
#3876 closed Bug (fixed)
Dialog elements should use explicit labels instead of implicit labels.
| Reported by: | martinkou | Owned by: | martinkou |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | Accessibility | Version: | SVN (CKEditor) - OLD |
| Keywords: | IBM Confirmed Review+ | Cc: | damo |
Description
Most dialogs elements in CKEditor 3 are using implicit labels at the moment. e.g.
<label id="68_uiElement" class="cke_dialog_ui_checkbox">
<input class="cke_dialog_ui_checkbox_input"
id="67_uiElement"
type="checkbox" />
Match whole word
</label>
Checkpoint 12.4 of the WCAG 1.0 standard recommends explicit labels to be used instead.
Attachments (2)
Change History (7)
Changed 8 years ago by martinkou
comment:1 Changed 8 years ago by martinkou
- Keywords Review? added
comment:2 Changed 8 years ago by garry.yao
- Keywords Review- added; Review? removed
The new form of label violate Checkpoint 10.2:
The label must immediately precede its control on the same line (allowing more than one control/label per line) or be in the line preceding the control (with only one label and one control per line).
comment:3 Changed 8 years ago by martinkou
- Keywords Review? added; Review- removed
Checkpoint 10.2 only applies to implicit labels. The rational for the recommendation is that screenreaders wouldn't be able to know which input to associate a label to if the label isn't placed at certain places. Now that we have converted to explicit labels, checkpoint 10.2 does not apply any more
There's one small problem in yesterday's patch, though. In Firefox, the space between the input elements and the labels have disappeared. I'm proposing another patch to fix this.
Changed 8 years ago by martinkou
comment:4 Changed 8 years ago by garry.yao
- Keywords Review+ added; Review? removed
comment:5 Changed 8 years ago by martinkou
- Resolution set to fixed
- Status changed from new to closed
Fixed with [3810].
Click here for more info about our SVN system.

Changed the labels of radio buttons and checkboxes in dialogs to explicit style.