Ticket #3882 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

pasteFromWordRemoveStyle config key ignored

Reported by: dprice Owned by: arczi
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: 3.0 RC
Keywords: Confirmed Review+ Cc:

Description

A default value of false is set _source/plugins/pastefromword/plugin.js for CKEDITOR.config.pasteFromWordRemoveStyle, but this config key is not used anywhere. I am attaching a simple patch to cause this key to set the default value for the "Remove Styles" checkbox in the Paste from Word dialog.

Keep up the great work!

Attachments

ckeditor-config-pastefromword-removestyle.diff (620 bytes) - added by dprice 5 years ago.
two line change to implement default checkbox value based on config key
3882.patch (1.4 KB) - added by arczi 5 years ago.
3882_2.patch (1.5 KB) - added by arczi 5 years ago.

Change History

Changed 5 years ago by dprice

two line change to implement default checkbox value based on config key

comment:1 Changed 5 years ago by arczi

  • Status changed from new to assigned
  • Owner set to arczi
  • Type changed from New Feature to Bug
  • Keywords Confirmed added; pastefromword config removestyle removed
  • Summary changed from pasteFromWordRemoveStyle config key ignored [PATCH INCLUDED] to pasteFromWordRemoveStyle config key ignored

Changed 5 years ago by arczi

comment:2 Changed 5 years ago by arczi

  • Keywords Review? added

comment:3 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review- added; Review? removed

I'm sorry Artur but it seems that you're using undeclared pasteFromWordRemoveStyle and pasteFromWordIgnoreFontFace variables, instead of using those from config.

Changed 5 years ago by arczi

comment:4 Changed 5 years ago by arczi

  • Keywords Review? added; Review- removed

comment:5 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review+ added; Review? removed

comment:6 Changed 5 years ago by arczi

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3851]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy