Opened 16 years ago
Closed 16 years ago
#3903 closed Bug (fixed)
Unable to override font colors
| Reported by: | Josh Nisly | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | HasPatch Review+ | Cc: |
Description
The config.colorButton_colors setting allows overriding the colors that are shown in the font and background color dropdowns. However, because of a bug in _source/plugins/colorbutton/plugin.js, this setting is not respected.
The solution is to check config.colorButton_colors instead of CKEDITOR.config.colorButton_colors. This is similar to how other plugins work.
Attached is a patch.
Attachments (1)
Change History (6)
Changed 16 years ago by
| Attachment: | 3903.patch added |
|---|
comment:1 Changed 16 years ago by
| Keywords: | HasPatch added; hasPatch removed |
|---|---|
| Milestone: | → CKEditor 3.0 |
comment:2 Changed 16 years ago by
| Keywords: | Review+ added |
|---|
comment:3 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 16 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
[3830] only changed whitespace - the changes in the patch were never applied.
comment:5 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Definitely it's wrong, thanks for point it out.
Fixed with [3842].
Note: See
TracTickets for help on using
tickets.
Fixed with [3830].