Ticket #3903 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Unable to override font colors

Reported by: highjinx_53 Owned by:
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: HasPatch Review+ Cc:

Description

The config.colorButton_colors setting allows overriding the colors that are shown in the font and background color dropdowns. However, because of a bug in _source/plugins/colorbutton/plugin.js, this setting is not respected.

The solution is to check config.colorButton_colors instead of CKEDITOR.config.colorButton_colors. This is similar to how other plugins work.

Attached is a patch.

Attachments

3903.patch​ (521 bytes) - added by highjinx_53 4 years ago.

Change History

Changed 4 years ago by highjinx_53

comment:1 Changed 4 years ago by fredck

  • Keywords HasPatch added; hasPatch removed
  • Milestone set to CKEditor 3.0

comment:2 Changed 4 years ago by garry.yao

  • Keywords Review+ added

comment:3 Changed 4 years ago by garry.yao

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [3830].

comment:4 Changed 4 years ago by highjinx_53

  • Status changed from closed to reopened
  • Resolution fixed deleted

[3830] only changed whitespace - the changes in the patch were never applied.

comment:5 Changed 4 years ago by garry.yao

  • Status changed from reopened to closed
  • Resolution set to fixed

Definitely it's wrong, thanks for point it out.
Fixed with [3842].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy