Ticket #3910 (closed New Feature: invalid)

Opened 5 years ago

Last modified 2 years ago

Improved spellerPages

Reported by: harrytheb2 Owned by:
Priority: Normal Milestone:
Component: UI : Spell Checker Version: FCKeditor 2.6.4
Keywords: HasPatch Cc: gtansey_fck@…, pucku@…

Description

I've made some modifications to the speller pages script that I thought might be useful and worth sharing.

Changed files are attached

  • By setting FCKConfig.SpellerPagesAddButton to true, the speller pages will include an 'add' (to dictionary) button. Without this setting it's entirely backwards compatible. With it enabled, any words that are added are posted back to the server through the spell checking script with a parameter set to enable it to detect that words need to be added to the dictionary, rather than to do a spell check.
  • The spellchecker.pl script has been modified and has placeholder functions for adding/retrieving words from the dictionary according to the server setup.
  • The control window has been improved to enable/disable buttons when appropriate.
  • The OK button is enabled on the outer spellchecking dialog when appropriate. This means you don't have to spell check an entire document and can finish half-way through to apply changes.
  • The word window has been fixed so as not to try to find mispelled words within HTML tags (see also bugs #2470 #2326 #2158 which also mention this but it still doesn't seem to have been fixed)

I'm not familiar with PHP or CFM but I'm sure it would be straightforward for someone who is to make similar changes in those scripts.

Attachments

spellerpages.zip (14.9 KB) - added by harrytheb2 5 years ago.
changed files from FCK2.6.4 for improved spellerPages
3910.patch (31.5 KB) - added by harrytheb2 5 years ago.
patch file for diffs from http://svn.fckeditor.net/FCKeditor/tags/2.6.4

Change History

Changed 5 years ago by harrytheb2

changed files from FCK2.6.4 for improved spellerPages

comment:1 Changed 5 years ago by mosipov

Please read this if you want to submit an improvement.

comment:2 Changed 5 years ago by harrytheb2

  • Keywords Review? added
  • Cc gtansey_fck@… added

I've attached a patch file after applying the changes to a checkout from http://svn.fckeditor.net/FCKeditor/tags/2.6.4

I'm not sure if you want a patch from a checkout from the trunk? But I'm suggesting that before this would be ready to go on the trunk that some equivalent changes to those made in editor/dialog/fck_spellerpages/spellerpages/server-scripts/spellchecker.pl be also made to the .php and .cfm scripts. Perhaps this needs to go in a branch - not sure how you want to work with this, but I do think it would be a useful enhancement. Let me know if I can help further.

Changed 5 years ago by harrytheb2

comment:3 Changed 5 years ago by fredck

  • Keywords HasPatch added; Review? removed
  • Component changed from General to UI : Spell Checker

Thanks for the patch. The review instead must be asked for one of our core devs. I'm properly setting the ticket fields.

comment:4 Changed 4 years ago by SpellChecker.net

It is not SpellChecker.net related bug - doesn't relate to wsc or scayt plug-ins.

comment:5 Changed 4 years ago by pucku

  • Priority changed from Normal to High
  • Cc pucku@… added

harrytheb2, I applied your changes, but I didn't see the ADD button, so I edited the fck_spellerpages.html file by changing 'undefined' to 'true'. Here's the line:

oSpeller.bUseAddButton = (typeof oEditor.FCKConfig.SpellerPagesAddButton != 'true' && oEditor.FCKConfig.SpellerPagesAddButton) ? true : false;

That didn't work, so I starting digging and then I changed a line in the controls.html file to:

<input class="buttonDefault" type="button" id="btnAdd" fckLang="DlgSpellBtnAdd" value="Add" onClick="addWord();" disabled>

Now what happens is that when you click the spell check button, you see the ADD button and then it quickly disappears.

Am I editing the correct files?

Thanks!

comment:6 Changed 4 years ago by fredck

  • Priority changed from High to Normal
  • Version set to FCKeditor 2.6.4

comment:7 Changed 2 years ago by j.swiderski

  • Status changed from new to closed
  • Resolution set to invalid

FCKeditor was retired and is no longer supported. All active development was moved to its successor, CKEditor 3.x, that is a fully mature and far superior product. We recommend you upgrade as soon as possible.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy