list operation doesn't stop at table

[garry.yao]

Reproducing Procedures

1. Open the attached example page.
2. Select the table cell content, and click 'Create/Remove Bullted List'.
   • Actual Result:
     • list

       list in table

   • Expected Result:
     1. list

        list in table

[garry.yao]

Sample page for reproducing

[tobiasz.cudnik]

This patch forbids to merge cell elements with table-wrapping list. It's also possible to create list selecting multiple block and table cells.

[garry.yao]

We should not target only the specific <td> tag on line L421:

if ( block.getName() != 'td' )

instead we could have:

if ( blockLimit.getName() != 'body' )

[tobiasz.cudnik]

It doesn't perform so well with blockLimit check if "body". ​Video TC.

[garry.yao]

Thanks for the video TC, I haven't test it, just want to explain my point, I mean we could group by blockLimit prior to grouping by ancestor list, and please test the patch carefully with enterkey, indent etc.

[tobiasz.cudnik]

Now condition checks if blockLimit is a body or block is nested list element and then allows to grouping by list ancestor.

What's missing i think is turning off list button ON state when focusing non-list inside a table which is inside a list.

One issue is closely releted list nested inside a table from indent plugin. When clicking enter second time to create new list element, JS error is thrown and bookmarks can be found in markup. Although this issue is not an regression and exists in trunk.

[tobiasz.cudnik]

Garry extended the patch by providing toolbar button state changing and correcting indent plugin issue.

[garry.yao]

Fixed with [3914].