Opened 7 years ago

Closed 6 years ago

#4090 closed New Feature (fixed)

CKEditor support for Adobe AIR

Reported by: fredck Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5
Component: General Version:
Keywords: Umbrella Cc:

Description (last modified by garry.yao)

CKEditor should run properly on Adobe AIR in application sandbox. This is an umbrella ticket, it points to several tickets which mostly targeting workaround for editor's original design goals which violate AIR's security rules.

inline event handler violation

Inline event handlers are ignored in AIR

iframe loading violation

All float panels are broken in AIR

Change History (10)

comment:1 Changed 7 years ago by garry.yao

  • Keywords Discussion added

Well, we definitely have much trouble with Adobe AIR support on application sandbox comparing with v2, majorly because we violate many AIR HTML security rules in v3:

  1. “javascript:” URI scheme ( Violated by wysiwyg iframe loading )
  2. document.write() after page onload happened ( violated by wysiwyg iframe loading either )
  3. parsing handler attributes (e.g. onclick="myFunction();") inserted with innerHTML or outerHTML ( Violated by almost every handler on UI items )

For 1 and 2, we could find workaround easily with some feature sacrifices( content doc type, content doc lang direction... ), but for 3, it will take some efforts.

Not sure if non-application-sandbox's even be a fall-back option for us?

comment:2 Changed 7 years ago by garry.yao

And it seems for me that dynamic <style> tag are also ignored.

comment:3 Changed 7 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

New feature branch for AIR support has been created and a plugin 'adobeair' has been committed with [4294].

comment:4 Changed 7 years ago by garry.yao

  • Description modified (diff)
  • Keywords Umbrella added; Discussion removed
  • Milestone changed from CKEditor 3.1 to CKEditor 3.2

Though at this moment we've almost code complete with this feature, while there's not much time left for us to properly testing everything to guarantee the quality, we've decided to ship it with next release.

comment:5 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.2 to CKEditor 3.3

comment:6 Changed 7 years ago by garry.yao

  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

We would like to defer the support for AIR to next release, which will probably feature AIR2 which is currently under beta.

comment:7 Changed 6 years ago by fredck

  • Keywords Confirmed removed
  • Milestone changed from CKEditor 3.4 to CKEditor 3.5

comment:8 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.4.1 to CKEditor 3.5

comment:9 Changed 6 years ago by fredck

The code proposed in the adobeair branch is unacceptable. It demonstrates a strong lack of attention on details. It also introduces code formatting on some files, which makes reviewing much complicated.

comment:10 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

the "adobeair" branch lands on 3.5.x with [6178].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy