Ticket #4111 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

JS error while applying style

Reported by: arczi Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: Core : Styles Version:
Keywords: Firefox Confirmed Review+ Cc:

Description

Steps to reproduce:

  • Open 'replacebyclass'
  • Select all text using mouse
  • Click Bold
  • Click Bold one more time
  • Select "Heading 1" from Format combo

Result:

node is null
http://localhost/edytor/CKEditor/trunk/_source/core/dom/range.js
Line 1369

anonymous()range.js (line 1369)
anonymous()range.js (line 1574)
anonymous()plugin.js (line 75)
applyBlockStyle()plugin.js (line 680)
anonymous()plugin.js (line 130)
applyStyle()plugin.js (line 1200)
anonymous()plugin.js (line 115)
anonymous()plugin.js (line 58)
anonymous()plugin.js (line 257)
anonymous()plugin.js (line 65)
anonymous()tools.js (line 505)
anonymous()tools.js (line 512)

It is not an regression.

Attachments

4111.patch (1.8 KB) - added by garry.yao 5 years ago.
4111_2.patch (1.8 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Keywords Firefox Confirmed added
  • Status changed from new to assigned
  • Owner set to garry.yao

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

  • Keywords Review? added

comment:3 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

The new "marker" variable may not always exist and a new error now happens. Because of this, the new line 502 must look like:

marker && marker.remove();

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed

:/

comment:5 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:6 follow-up: ↓ 7 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with #3977.

comment:7 in reply to: ↑ 6 Changed 5 years ago by garry.yao

Replying to garry.yao:

Fixed with #3977.

Typo: Fixed with [3977].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy