Opened 8 years ago
Closed 8 years ago
#4119 closed Bug (fixed)
[IE] Unable to edit link around image with image dialog
| Reported by: | garry.yao | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description (last modified by garry.yao)
Reproducing Procedures
- Open the 'replace by class' sample page in IE;
- Load the document will following content:
<a href="ckeditor.com"><img alt="title" height="43" src="http://dev.fckeditor.net/chrome/site/logos.gif" width="207" /></a>
- Select the 'img' element with elements path bar.
- Open 'Image' dialog and switch to 'Link' tab;
- Actual Result: The link is not loaded.
Attachments (1)
Change History (6)
comment:1 Changed 8 years ago by fredck
comment:2 Changed 8 years ago by garry.yao
- Keywords Confirmed Review? added; IE removed
- Status changed from new to assigned
comment:3 Changed 8 years ago by garry.yao
- Description modified (diff)
Correct TC according to Fred's comment.
Changed 8 years ago by garry.yao
comment:4 Changed 8 years ago by fredck
- Keywords Review+ added; Review? removed
comment:5 Changed 8 years ago by garry.yao
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
The logic in the image dialog at line 219 is totally wrong. It expects a link to be selected, and this will never happen to the image dialog. We'll "always" have and image selected, never a link. The point 3 in the above TC is wrong.
The link dialog must check the image parent checking it it's a link. It was enough to copy the V2 behavior here :/