Opened 7 years ago

Closed 7 years ago

#4119 closed Bug (fixed)

[IE] Unable to edit link around image with image dialog

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version:
Keywords: Confirmed Review+ Cc:

Description (last modified by garry.yao)

Reproducing Procedures

  1. Open the 'replace by class' sample page in IE;
  2. Load the document will following content:
    <a href="ckeditor.com"><img alt="title" height="43" src="http://dev.fckeditor.net/chrome/site/logos.gif" width="207" /></a>
    
  3. Select the 'img' element with elements path bar.
  4. Open 'Image' dialog and switch to 'Link' tab;
    • Actual Result: The link is not loaded.

Attachments (1)

4119.patch (2.6 KB) - added by garry.yao 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by fredck

The logic in the image dialog at line 219 is totally wrong. It expects a link to be selected, and this will never happen to the image dialog. We'll "always" have and image selected, never a link. The point 3 in the above TC is wrong.

The link dialog must check the image parent checking it it's a link. It was enough to copy the V2 behavior here :/

comment:2 Changed 7 years ago by garry.yao

  • Keywords Confirmed Review? added; IE removed
  • Status changed from new to assigned

comment:3 Changed 7 years ago by garry.yao

  • Description modified (diff)

Correct TC according to Fred's comment.

Changed 7 years ago by garry.yao

comment:4 Changed 7 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:5 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3989]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy