Opened 8 years ago
Closed 8 years ago
#4129 closed Bug (fixed)
[FF] Unable to remove list with Ctrl-A
| Reported by: | garry.yao | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | Core : Lists | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the 'replace by class' sample page in Firefox;
- Load the document with the following content and selection with Ctrl-A:
[<p>line1</p> <p>line2</p>]
- Click on 'Insert/Remove Bulleted List' button twice;
- Actual Result: The second click of remove list has no effect.
Attachments (2)
Change History (9)
comment:1 Changed 8 years ago by tobiasz.cudnik
- Keywords Confirmed added
- Owner set to tobiasz.cudnik
- Status changed from new to assigned
Changed 8 years ago by garry.yao
comment:2 Changed 8 years ago by garry.yao
- Keywords Review? added
- Owner changed from tobiasz.cudnik to garry.yao
- Status changed from assigned to new
comment:3 Changed 8 years ago by tobiasz.cudnik
- Keywords Review- added; Review? removed
Removing list works after second list-command with the patch, but after third one nothing is happening. Expected is that list will be created again.
comment:4 Changed 8 years ago by garry.yao
- Keywords Review? added; Review- removed
- Status changed from new to assigned
I'm trying to persuade that this patch's not being a drastic change:
- Changes in previous 4129.patch are leveraged without change.
- Changes to _source/plugins/wysiwygarea/plugin.js and _source/core/dom/element.js are because it's breaking the 'selectionChange' event
which stop the list command from freshing( Tobias's comment );
- Changes to _source/plugins/domiterator/plugin.js are necessary clean up to avoid extra list item ( contain only whitespace text ) been created when exec list command multiple times.
Changed 8 years ago by garry.yao
comment:5 Changed 8 years ago by tobiasz.cudnik
I can confirm that issues i've mentioned is fixed with second patch.
comment:6 Changed 8 years ago by fredck
- Keywords Review+ added; Review? removed
comment:7 Changed 8 years ago by garry.yao
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [4034].
Note: See
TracTickets for help on using
tickets.

After discussing with Tobias, I'm taking over this ticket.