Opened 8 years ago

Closed 8 years ago

#4139 closed Bug (fixed)

TCs in plugins/list are broken

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: Core : Styles Version:
Keywords: Confirmed Review+ Cc:

Description

Regression of [3894] and [3903] break the test.

Attachments (2)

4139.patch​ (2.3 KB) - added by garry.yao 8 years ago.
4139_2.patch​ (2.4 KB) - added by garry.yao 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by garry.yao

comment:1 Changed 8 years ago by garry.yao

  • Keywords Review? added
  • Status changed from new to assigned

comment:2 Changed 8 years ago by fredck

  • Keywords Review- added; Review? removed

The tests are passing on IE only with the patch. Don't pass in FF and Safari.

Changed 8 years ago by garry.yao

comment:3 follow-up: Changed 8 years ago by garry.yao

  • Keywords Review? added; Review- removed

#3872 is not reproduced any more at this point, so [3903] which break the TC is reverted.

comment:4 in reply to: ↑ 3 Changed 8 years ago by garry.yao

Replying to garry.yao:

#3872 is not reproduced any more at this point, so [3903] which break the TC is reverted.

Typo #3872 -> #3782.

comment:5 Changed 8 years ago by fredck

  • Keywords Review+ added; Review? removed

Ok... I'm leaving the Safari remaining failure to another ticket.

comment:6 Changed 8 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [4022].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy