Ticket #4177 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

[Safari] core/editor/test_config_inpage randomly failed

Reported by: garry.yao Owned by: fredck
Priority: Normal Milestone: CKEditor 3.0
Component: QA Version:
Keywords: Safari Confirmed Review+ Cc:

Description

The inline config should be checked only after 'configLoaded' is fired.

Attachments

4177.patch​ (1.6 KB) - added by garry.yao 4 years ago.
4177_2.patch​ (1.7 KB) - added by garry.yao 4 years ago.
4177_3.patch​ (1.7 KB) - added by garry.yao 4 years ago.
4177_4.patch​ (1.7 KB) - added by fredck 4 years ago.

Change History

Changed 4 years ago by garry.yao

comment:1 Changed 4 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned
  • Keywords Review? added

comment:2 Changed 4 years ago by fredck

  • Keywords Review- added; Review? removed

The event registration should be set in the replace call. If things are cached, the configLoaded could be called even before the event registration. It just happend to me with Firefox.

Changed 4 years ago by garry.yao

comment:3 Changed 4 years ago by garry.yao

  • Keywords Review? added; Review- removed

Changed 4 years ago by garry.yao

Changed 4 years ago by fredck

comment:4 Changed 4 years ago by fredck

  • Owner changed from garry.yao to fredck
  • Status changed from assigned to new

I've made some small simplifications to it.

comment:5 Changed 4 years ago by tobiasz.cudnik

  • Keywords Review+ added; Review? removed

comment:6 Changed 4 years ago by fredck

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [4044].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy