Opened 7 years ago

Closed 6 years ago

#4197 closed Bug (fixed)

[Safari] format combo don't hide when editor blur

Reported by: garry.yao Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Floating Panel Version: SVN (CKEditor) - OLD
Keywords: Safari Confirmed Review+ Cc:

Description (last modified by garry.yao)

Reproducing Procedures

  1. Open the 'replace by class' sample page in Safari;
  2. Open the 'Format' Combo, then click outside editor chrome;
    • Actual Result: combo panel won't able to hide from now on;

Attachments (2)

4197.patch (618 bytes) - added by m.nguyen 6 years ago.
With Safari and Chorme the 'elementPath' allways miss 'lastElement' object
4197_2.patch (452 bytes) - added by m.nguyen 6 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.1
  • Priority changed from High to Normal

It's possible to close the combo by clicking on it again, at least.

comment:2 Changed 7 years ago by garry.yao

  • Summary changed from [Safari] Float panel don't hide when editor blur to [Safari] format combo don't hide when editor blur

The problem happens to 'Format' Combo specifically, modify summary.

comment:3 Changed 7 years ago by garry.yao

  • Description modified (diff)
  • Version set to SVN (CKEditor)

Tidied description a bit.

comment:4 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.1 to CKEditor 3.2

comment:5 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.2 to CKEditor 3.3

comment:6 Changed 6 years ago by garry.yao

Even worse, 'Format' combo will not open at all on first click (without focus editor).

Changed 6 years ago by m.nguyen

With Safari and Chorme the 'elementPath' allways miss 'lastElement' object

comment:7 Changed 6 years ago by m.nguyen

  • Keywords Review? added
  • Owner set to m.nguyen
  • Status changed from new to assigned

comment:8 Changed 6 years ago by alfonsoml

  • Keywords Review- added; Review? removed

First of all, I've tried to reproduce the bug with Safari on windows but it behaved correctly.

The patch addresses the current ticket, but why isn't lastElement available in elementPath? other code might face this same problem so it might be worth to look at the problem at its root.

Also, I understand that this problem wasn't generating an error in the console, so if there's a try catch in the code that calls this, maybe it should be disabled (at least in _source mode) to find more easily this problems, or use the catch an ignore only expected failures.

Changed 6 years ago by m.nguyen

comment:9 Changed 6 years ago by m.nguyen

  • Keywords Review? added; Review- removed

When we click directly in 'Format' Combo (not focus editor), we will have an error. This bug happens (in Chorme and Safari) because the line code selection.getStartElement() http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/stylescombo/plugin.js#L157 returns null. This also happens in IE but we have already fixed by setting editor focus before getting selection.

comment:10 Changed 6 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:11 Changed 6 years ago by m.nguyen

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5318].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy