Opened 7 years ago

Closed 6 years ago

#4487 closed Bug (fixed)

FCKEditor 2.6.5 Does Not work with Safari 3.2.1

Reported by: ruben.g Owned by: fredck
Priority: Normal Milestone: FCKeditor 2.6.6
Component: General Version: FCKeditor 2.6.5
Keywords: Confirmed Safari Review+ Cc:

Description

I just updated to FCKEditor 2.6.5 to fix a height issue with Safari 4, but now Safari 3.2.1 doesn't display anything in the editor -- I also can't type anything in there.

This was working without any problems on both versions of Safari before the update. I'm using the replace text field method in case it helps. Don't hesitate to email me for more information.

Attachments (2)

proposal-section.png (30.5 KB) - added by ruben.g 7 years ago.
Screenshot of issue
4487.patch (1019 bytes) - added by fredck 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by ruben.g

Screenshot of issue

comment:1 Changed 7 years ago by domenm

Hi,

i had the same problem. i review all the changes in my svn and found a "bug/solution".

in file "fckeditor.html (line 270) and fckeditor.original.html (line 378)" in "fckeditor/editor" folder

If i change

if ( FCKBrowserInfo.IsGecko || FCKBrowserInfo.IsSafari )

to

if ( FCKBrowserInfo.IsGecko && !FCKBrowserInfo.IsOpera )

FCK works again in Safari 3.2.1, but i guess that in Safari 4 the height problem appears again.

comment:2 follow-up: Changed 6 years ago by alfonsoml

  • Resolution set to wontfix
  • Status changed from new to closed

It's not possible to download Safari 3 from http://www.apple.com/safari/download/ so testing such environments isn't easy as they would require to keep some system with updates disabled

The described change is not feasible as that would mean that now IE also might execute that code, and if we leave that aside and only consider Opera and Safari, testing for IsOpera is the same that checking for IsSafari.

comment:3 in reply to: ↑ 2 Changed 6 years ago by fredck

  • Keywords Confirmed Safari added
  • Milestone set to FCKeditor 2.6.6
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Replying to alfonsoml:

It's not possible to download Safari 3 from http://www.apple.com/safari/download/

Here you have it, for Leopard, Tiger and Windows.

Testing such environments isn't easy as they would require to keep some system with updates disabled

That's true... but it looks like we have options for it:
http://michelf.com/projects/multi-safari/

In fact I was able to reproduce and confirm the bug.

The described change is not feasible as that would mean that now IE also might execute that code, and if we leave that aside and only consider Opera and Safari, testing for IsOpera is the same that checking for IsSafari.

True... I'll be providing a patch for it.

Changed 6 years ago by fredck

comment:4 Changed 6 years ago by fredck

  • Keywords Review? added
  • Owner set to fredck
  • Status changed from reopened to new

I'm proposing the same version detection code we use on V3.

comment:5 Changed 6 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

Those links are interesting. I've heard too many times of IE Tester but I never show this option for Safari, and virtualising Mac OS X isn't too easy (as it's expensive to buy the Server version).

comment:6 Changed 6 years ago by fredck

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with [5123].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy