Ticket #4522 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[IE] Unable to redo on inserted element + typing

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Undo & Redo Version: SVN (CKEditor) - OLD
Keywords: IE Review+ Cc:

Description

Environments

IE6/IE7 (IE8 works well)

Procedures

  1. Focus the editor;
  2. Open the 'Smiley' dialog and insert an icon;
  3. Start typing a few words;
  4. Press 'Undo' button or 'Ctrl-Z' key;
  • Actual Result: Typed words are removed;
  1. Press 'Undo' button or 'Ctrl-Z' key again;
  • Expected Result: Icon is removed.
  • Actual Result: Unable to remove the icon, even 'Undo' button is enable there.

Attachments

4522.patch (1.0 KB) - added by garry.yao 5 years ago.
4522_2.patch (922 bytes) - added by garry.yao 5 years ago.
4522_3.patch (1.1 KB) - added by garry.yao 5 years ago.

Change History

Changed 5 years ago by garry.yao

comment:1 Changed 5 years ago by garry.yao

  • Keywords Review? added
  • Status changed from new to assigned
  • Owner set to garry.yao

comment:2 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

I don't see any difference after the patch.

Changed 5 years ago by garry.yao

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed
  • Version set to SVN (CKEditor)

@fredck You're using IE8 quirks mode for testing and the above patch has wrong detection.

It's even safer to target the fix to all browsers.

comment:4 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

We should not make this fix viral, impacting on the performance of good browsers. Let's limit this fix to IE only, using CKEDITOR.env.ie8Compat to avoid it into IE8 also (as long as it's really true that IE8 is ok with it).

Changed 5 years ago by garry.yao

comment:5 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:6 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4605].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy