Ticket #4547 (closed New Feature: fixed)

Opened 5 years ago

Last modified 5 years ago

Load the skin CSS in parallel

Reported by: fredck Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: 3.0
Keywords: Confirmed Cc:

Description

We're currently loading the skin CSS files only after the plugins files get loaded. This is not really necessary, and these files could be loaded in parallel, while the rest of the editor scripts get loaded.

Attachments

4547.patch (916 bytes) - added by garry.yao 5 years ago.
4547_firebug_netpanel_snapshots.png (39.4 KB) - added by garry.yao 5 years ago.
Result Comparison

Change History

comment:1 Changed 5 years ago by fredck

The solution for it could be quite simple. It's enough to (unblocked) load the skin files as the first thing right after loading the configuration file.

comment:2 Changed 5 years ago by fredck

Changed 5 years ago by garry.yao

Changed 5 years ago by garry.yao

Result Comparison

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review? added
  • Owner set to garry.yao
  • Status changed from new to assigned

comment:4 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

The callback function at line 256 should not be removed. It'll not block for CSS files. It blocks only if the skin.js file needs to be downloaded.

Inside the above callback, we must call loadLang now, removing the call for it at line 130.

comment:5 Changed 5 years ago by garry.yao

Depends on #4463.

comment:6 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed by #4463.

comment:7 Changed 5 years ago by garry.yao

  • Keywords Review- removed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy