Ticket #4615 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Dialog fields are disrupted in RTL mode and IE

Reported by: Saare Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: 3.0.1
Keywords: IE Cc:

Description

To reproduce:
go to the "multi-language interface" demo and choose Hebrew or Arabic (both languages are in RTL mode).
open the link dialog.
focus on the URL field, and notice that the marker is getting out of the box a bit to the right. write something and notice that the first character is also getting out of the box.

Attachments

4615.patch (535 bytes) - added by Saare 5 years ago.
4615.2.patch (1.5 KB) - added by Saare 5 years ago.
Revised patch to fit all skins
4615_3.patch (1.5 KB) - added by Saare 4 years ago.
Align patch with the recent changes
4615_4.patch (1.3 KB) - added by Saare 4 years ago.

Change History

comment:1 follow-up: ↓ 5 Changed 5 years ago by fredck

  • Keywords Confirmed IE added

While I don't see the caret outside the box, I'm not even able to see it, as it looks like it's exactly over the border. There is no padding on it actually. It happens with all dialog fields actually.

Ok with Firefox.

comment:2 Changed 5 years ago by Saare

Also in the Search and Replace dialog.

comment:3 Changed 5 years ago by Saare

  • Milestone set to CKEditor 3.3

comment:4 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.3 to CKEditor 3.x

comment:5 in reply to: ↑ 1 Changed 5 years ago by Saare

Replying to fredck:

It happens with all dialog fields actually.

Actually i can't see the bug in all dialogs, just in some. this is quite odd since this is the same CSS definition.

comment:6 Changed 5 years ago by Saare

Forgot to mention in the above, also in Selection field dialog.

Changed 5 years ago by Saare

comment:7 Changed 5 years ago by Saare

  • Status changed from new to assigned
  • Owner set to Saare
  • Keywords Review? added

Changed 5 years ago by Saare

Revised patch to fit all skins

comment:8 Changed 4 years ago by Saare

  • Milestone changed from CKEditor 3.x to CKEditor 3.3

This is a small fix with no risk for a really annoying bug, so i hope it could get fixed in 3.3.

comment:9 Changed 4 years ago by fredck

  • Keywords HasPatch added; Review? removed

Thanks for the patch Saare. Let's wait for a core developer to ask for review.

comment:10 Changed 4 years ago by Saare

  • Status changed from assigned to new
  • Summary changed from URL field in the link dialog disrupted in RTL mode and IE to Dialog fields are disrupted in RTL mode and IE

comment:11 Changed 4 years ago by Saare

  • Owner changed from Saare to --

comment:12 Changed 4 years ago by garry.yao

  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

comment:13 Changed 4 years ago by Saare

  • Keywords Review? added; HasPatch removed
  • Status changed from new to assigned
  • Owner changed from -- to Saare

Changed 4 years ago by Saare

Align patch with the recent changes

comment:14 Changed 4 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

comment:15 Changed 4 years ago by Saare

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5665].

comment:16 Changed 4 years ago by fredck

  • Status changed from closed to reopened
  • Keywords Confirmed Review+ removed
  • Resolution fixed deleted

I can still see this issue on trunk.

comment:17 Changed 4 years ago by Saare

I'm not able to reproduce it in any way.

Changed 4 years ago by Saare

comment:18 Changed 4 years ago by Saare

  • Status changed from reopened to review

After a conversation with Fred we concluded that it's better to have a small spacing in some of the machines rather than not being able to see the caret in others.

comment:19 Changed 4 years ago by fredck

  • Status changed from review to closed
  • Resolution set to fixed

:/ it still doesn't work for me.

I have then put 10px there... there is a lot of padding in the field, as expected, but the caret never shows at the start of the text, just at the middle of it.

This is definitely another IE bug, which impacts on just a few machines. Let's have a dedicated ticket for it, leaving this one as closed.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy