Opened 15 years ago
Closed 14 years ago
#4652 closed Bug (fixed)
Config for disable editor context menu
| Reported by: | Garry Yao | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5 |
| Component: | UI : Context Menu | Version: | |
| Keywords: | Cc: |
Description
We should provide an option for disable context menu in editor, probably porting #311 from v2.
Attachments (3)
Change History (17)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
| Milestone: | CKEditor 3.2 → CKEditor 3.3 |
|---|
comment:3 Changed 15 years ago by
| Milestone: | CKEditor 3.3 → CKEditor 3.4 |
|---|
Changed 15 years ago by
| Attachment: | 4652.patch added |
|---|
comment:4 Changed 15 years ago by
| Keywords: | Confirmed Review? added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
'contextmenu' plugin is no longer required by 'menubutton' thus can be removed from plugin list to reveal the native context menu.
comment:5 Changed 15 years ago by
It seems to me that the overall idea and changes are OK, but due to the number of changes, I would like that someone else could look also at the patch.
comment:6 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
There's some error with this patch:
in IE8, select some word and open the context menu, dismiss it, select something else and trying to open the context menu will throw an error. If the second time nothing is selected, the context menu opens, and when it's closed it selects back the first range.
comment:7 Changed 15 years ago by
| Milestone: | CKEditor 3.4 → CKEditor 3.5 |
|---|
comment:8 Changed 15 years ago by
| Owner: | changed from Garry Yao to Tobiasz Cudnik |
|---|---|
| Status: | review_failed → assigned |
I'm taking this one over Garry.
Changed 15 years ago by
| Attachment: | 4652_2.patch added |
|---|
comment:9 Changed 15 years ago by
| Status: | assigned → review |
|---|
Reason for non unlocked selection on IE was unexecuted onHide listener.
comment:10 Changed 15 years ago by
| Milestone: | CKEditor 3.4.1 → CKEditor 3.5 |
|---|
comment:11 Changed 14 years ago by
| Status: | review → review_failed |
|---|
There's an error thrown when menu is hide at L145 of menu/plugin.js.
Changed 14 years ago by
| Attachment: | 4652_3.patch added |
|---|
comment:12 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:14 Changed 14 years ago by
| Keywords: | Confirmed removed |
|---|---|
| Resolution: | → fixed |
| Status: | review_passed → closed |
Fixed with [5937].
Actually here we just need to make it possible to disable it by simply remove the plugin itself, no new config introduced.