Ticket #4673 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Undo not available straight away if shift key is used to enter first character.

Reported by: JoeK Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Undo & Redo Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: dchojna@…

Description

When entering some text into the editor use the shift key to capitalize the first character. Observe that the Undo button is not active until about 15 characters have been entered.

Attachments

4673.patch (2.7 KB) - added by garry.yao 5 years ago.
4673_2.patch (2.7 KB) - added by garry.yao 5 years ago.
4673_3.patch (1.2 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned
  • Version changed from 3.0.1 to SVN (CKEditor)
  • Keywords Confirmed added

Nice catch, this's something that definitely need to fix right now.

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

Update key map of editing keys, modifier keys and navigation keys according to: keyboard keys

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review? added

comment:4 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

Please remove the space and tab keys from the editing list as having snapshots for each space reduces the undo stack too much, considering that it's a very very common key (the most common).

Changed 5 years ago by garry.yao

comment:5 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:6 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4607].

comment:8 Changed 5 years ago by damo

  • Status changed from closed to reopened
  • Resolution fixed deleted

This is still reproducible, although the steps to reproduce are slightly different.

  1. Use Ajax sample.
  2. Create editor and focus into body.
  3. Press CAPS Lock once. (This means toggle once, it does not matter if it is on or off)
  4. Type into the editor.

Notice that undo does not activate.

Reproduced on FF 3.5 & IE 7

Changed 5 years ago by garry.yao

comment:9 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review+ removed

comment:10 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:11 Changed 5 years ago by garry.yao

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed with [4817].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy