Opened 15 years ago
Closed 15 years ago
#4690 closed Bug (fixed)
htmlParser goes wrong with empty inline elements
| Reported by: | Garry Yao | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | Core : Output Data | Version: | SVN (CKEditor) - OLD |
| Keywords: | Confirmed Review+ | Cc: |
Description
Having htmlParser deal with the following input:
<span><span></span>text</span>
With incorrectly yield:
text
Attachments (3)
Change History (12)
Changed 15 years ago by
| Attachment: | 4690.patch added |
|---|
comment:1 Changed 15 years ago by
| Keywords: | Confirmed Review? added |
|---|---|
| Milestone: | → CKEditor 3.1 |
| Owner: | set to Garry Yao |
| Status: | new → assigned |
| Version: | → SVN (CKEditor) |
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Definitely makes sense. You may fix the comment to "a pending tag".
comment:4 Changed 15 years ago by
| Keywords: | Review- added; Review+ removed |
|---|
R- for failing the following TC:
assert.areSame( '<span class="outer">text</span>', htmlParse( '<span class="outer"><span></span>text</span>' ) );
Changed 15 years ago by
| Attachment: | 4690_2.patch added |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Previous patch was closing the pending element in wrong direction.
comment:6 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|---|
| Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
| Status: | assigned → new |
I've just found out that the code just needs to be simplified to make it work. I'll come with a new patch for it.
Changed 15 years ago by
| Attachment: | 4690_3.patch added |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Status: | new → assigned |
The pending list must be the first thing to get checked when closing a tag.
comment:8 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
That's a perfect fix, plz mark the ticket TC as stable after fixed.
Note: See
TracTickets for help on using
tickets.
Ticket Test added at :
http://ckeditor.t/tt/4690/1.html.