Opened 6 years ago

Closed 6 years ago

#4779 closed New Feature (fixed)

Setting CKEditor width should automatically adjust resize_minWidth

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Toolbar Version:
Keywords: Confirmed Review+ Cc:

Description

same applies for editor height.

Consider the following scenario: page with a column having fixed width 540px and padding 20px. Developer sets CKEditor width to 500px.

Now user entering text in CKEditor wants to change editor's height. What will happen? CKEditor will automatically resize to 750px (default resize_minWidth is 750px).

Instead of forcing developers to look for resize_minWidth and setting it to lower value than width, I think we should change resize_minWidth to width automatically if width has been set and is lower than resize_minWidth.

Attachments (2)

4779.patch (2.6 KB) - added by garry.yao 6 years ago.
4779_2.patch (3.1 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by fredck

  • Keywords Confirmed added
  • Milestone set to CKEditor 3.3

comment:2 Changed 6 years ago by wwalc

  • Summary changed from Setting CKEditor width should automatically adjust resize_maxwidth to Setting CKEditor width should automatically adjust resize_minWidth

comment:3 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

comment:4 Changed 6 years ago by garry.yao

  • Component changed from General to UI : Toolbar
  • Milestone changed from CKEditor 3.4 to CKEditor 3.3

I see this actually a pretty common case and I've seen others complained of it in forum.
In effect it happens even there's no configured width/height, but whenever the start layout size of editor is somehow smaller than our default value (750px), in such case, by setting min_resize value to actual size will prevent editor from shrinking, so how about having a dynamic min_resize setting to 1/2 of the original size?

Changed 6 years ago by garry.yao

comment:5 Changed 6 years ago by garry.yao

  • Keywords Review? added
  • Owner set to garry.yao
  • Status changed from new to assigned

comment:6 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

comment:7 Changed 6 years ago by fredck

  • Keywords Review- added; Review? removed

250 may be a too small value. So, let's make it simple (KISS), by simply readjusting resize_minWidth to the start width if it's bigger than that.

Changed 6 years ago by garry.yao

comment:8 Changed 6 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:9 Changed 6 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

comment:10 Changed 6 years ago by alfonsoml

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5663]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy