Opened 16 years ago
Closed 16 years ago
#4781 closed Bug (fixed)
Insert any template content start with html table result in empty paragraph
| Reported by: | Garry Yao | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | Confirmed 3.0.2 Review+ | Cc: |
Description
Reproducing Procedures
- Open 'replacebyclass' sample pages, open 'Templates' dialog.
- Make sure 'Replace actual contents' is checked and click on 'Strange Template' to insert it.
Attachments (6)
Change History (18)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
| Keywords: | 3.0.2 added |
|---|
Changed 16 years ago by
| Attachment: | 4781.patch added |
|---|
comment:3 Changed 16 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Frederico Caldeira Knabben |
| Status: | new → assigned |
comment:4 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
That's the right fix, while two improvement could be considered:
- We could safely remove the short circuit at L1615, just be greedy to until meet the deepest editable element;
- White-spaces will break things.
Ticket Test added at :
http://ckeditor.t/tt/4781/1.html.
Changed 16 years ago by
| Attachment: | 4781_2.patch added |
|---|
Changed 16 years ago by
| Attachment: | 4781_3.patch added |
|---|
comment:5 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
I've refacted the moveToElementEditStart function, making it bulletproof.
Changed 16 years ago by
| Attachment: | 4781_4.patch added |
|---|
comment:7 Changed 16 years ago by
Tests updated for the latest patch:
http://ckeditor.t/tt/4781/1.html.
Changed 16 years ago by
| Attachment: | 4781_5.patch added |
|---|
comment:8 Changed 16 years ago by
Tests updated for the latest patch:
http://ckeditor.t/tt/4781/1.html
comment:9 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The patch works well for me except for the following issues:
- Changes in the walker are not used.
- Please cache the evaluator out of the function scope.
Changed 16 years ago by
| Attachment: | 4781_6.patch added |
|---|
comment:10 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:11 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|

Regression introduced with [4539].