Opened 6 years ago

Closed 6 years ago

#4790 closed Bug (fixed)

CKEditor in enterMode = BR, problem with bullet list

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4.3
Component: Core : Lists Version: 3.0
Keywords: Opera Cc:

Description

This ticket is similar to #3836. I think it happens only in Opera (tested on 10.10).

  1. Open the replace by code example page with enterMode = BR;
  2. Make the content and selection as below:
    line1
    <ul><li>[item1</li><li>item2]</li></ul>
    line2
    
  3. Click on 'Bullet List' to remove list;
  • Expected Result:
    line1<br />
    item1<br />
    item2<br />
    line2
    
  • Actual Result:
    line1<br />
    item1item2<br />
    line2
    

Attachments (1)

4790.patch (1.6 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by wwalc

  • Component changed from General to Core : Lists

comment:2 Changed 6 years ago by fredck

  • Milestone set to CKEditor 3.x

comment:3 Changed 6 years ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:4 Changed 6 years ago by krst

  • Summary changed from [Opera] to CKEditor in enterMode = BR, problem with bullet list

Changed 6 years ago by garry.yao

comment:5 Changed 6 years ago by garry.yao

  • Milestone set to CKEditor 3.5
  • Owner set to garry.yao
  • Status changed from confirmed to review

comment:6 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.5 to CKeditor 3.4.3

comment:7 follow-up: Changed 6 years ago by tobiasz.cudnik

It works well for me in Opera and others, although i'm thinking why not to change the appendBogus method which appends an empty text node for Opera only.

comment:8 in reply to: ↑ 7 Changed 6 years ago by fredck

Replying to tobiasz.cudnik:

It works well for me in Opera and others, although i'm thinking why not to change the appendBogus method which appends an empty text node for Opera only.

Do you mean having the entire fix there?

comment:9 Changed 6 years ago by garry.yao

I'm ok with fixing only appendBogus, while Fred had told me before for "some reason" that we kept using empty space as bogus for Opera.

comment:10 Changed 6 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

I'm not getting same results after patching just appendBogus, for first linebreak you have to hit Enter twice.

So R+ for the 4790 patch.

comment:11 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6112].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy