Opened 7 years ago

Closed 7 years ago

#4825 closed Bug (fixed)

Browser context menu is opened when clicking right mouse button twice

Reported by: wwalc Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: 3.0.1
Keywords: Confirmed Review+ Cc:

Description

This issue can be reproduced in any browser (tested in IE8, Safari 4.0.4, Opera 10.10, FF 3.5.5), but:

  • in FF 3.5.5 @ XP it doesn't happen always, however it happens often when right-clicking twice on a link

In FCKeditor I'm having this problem only in Opera.

Attachments (3)

4825.patch (572 bytes) - added by m.nguyen 7 years ago.
4825_2.patch (947 bytes) - added by m.nguyen 7 years ago.
Block context menu when action on menu
4825_3.patch (509 bytes) - added by m.nguyen 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by wwalc

  • Summary changed from Browser context menu is opened when clicking mouse button twice to Browser context menu is opened when clicking right mouse button twice

comment:2 Changed 7 years ago by fredck

  • Milestone set to CKEditor 3.3

Changed 7 years ago by m.nguyen

comment:3 Changed 7 years ago by m.nguyen

  • Keywords Review? added
  • Owner set to m.nguyen
  • Status changed from new to assigned

With the first right click we will show context menu, then second right click the mouse active on context menu (just show) not on editor. This is reason the default context menu show when we have twice right click. My approach only moves context menu a bit far from mouse's position.

comment:4 Changed 7 years ago by garry.yao

  • Keywords Review- added; Review? removed

It's a nice approach (actually also used in IE and FF), while the offset must be menu orientation sensitive, e.g. when menu is layout toward north (when opened at the bottom of the window), the justification must be applied as negative value.

comment:5 Changed 7 years ago by fredck

Considering that the menu is opened inside our stuff, aren't we able to block the context menu event instead of proposing a hack-like approach?

Changed 7 years ago by m.nguyen

Block context menu when action on menu

comment:6 Changed 7 years ago by m.nguyen

  • Keywords Review? added; Review- removed

comment:7 Changed 7 years ago by garry.yao

  • Keywords Review- added; Review? removed

Such logic is already [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/panel/plugin.js#L297

planted], we should make it works instead of repeating in another places.

Changed 7 years ago by m.nguyen

comment:8 Changed 7 years ago by m.nguyen

  • Keywords Review? added; Review- removed

Such logic is already http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/panel/plugin.js#L297

This line code using for prevent in content of context menu, while we need prevent the root block of context menu.

comment:9 Changed 7 years ago by garry.yao

  • Keywords Review+ added; Review? removed

Nice fix.

comment:10 Changed 7 years ago by m.nguyen

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5321].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy