Ticket #4940 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Setting config.customConfig = '' doesn't work

Reported by: alfonsoml Owned by: fredck
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

According to the docs of customConfig that's the way to avoid an extra request for the config file if it isn't needed, but the code in core/editor.js uses it this way:

	var loadConfig = function( editor )
	{
		var customConfig = CKEDITOR.getUrl( editor.config.customConfig );

		// Check if there is a custom config to load.
		if ( !customConfig )
			return false;

and the call to CKEDITOR.getUrl() returns the base url of CKEditor, so the return false isn't executed.

For this specific problem the "if ( !customConfig )" can be moved before the getUrl call, but maybe it would be better to change that function so it doesn't alter empty strings.

Attachments

4940.patch (730 bytes) - added by fredck 5 years ago.

Change History

comment:1 Changed 5 years ago by fredck

  • Keywords Confirmed added
  • Version set to SVN (CKEditor)
  • Milestone set to CKEditor 3.1

Regression introduced with [4585].

comment:2 Changed 5 years ago by fredck

  • Owner set to fredck
  • Status changed from new to assigned

Changed 5 years ago by fredck

comment:3 Changed 5 years ago by fredck

  • Keywords Review? added

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:5 Changed 5 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4871].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy