Ticket #4948 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Safari: table properties dialog sometimes does not detect parent table

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: 3.0
Keywords: Confirmed Safari Review+ Cc:

Description

Confirmed on Safari 4.0.4/XP3.

Steps to reproduce

  • start with the following source:
    <table border="1" cellpadding="1" cellspacing="1" style="width: 200px; " summary="some summary">
    	<caption>
    		some title</caption>
    	<tbody>
    		<tr>
    			<td>
    				&nbsp;</td>
    			<td>
    				&nbsp;</td>
    		</tr>
    		<tr>
    			<td>
    				&nbsp;</td>
    			<td>
    				&nbsp;</td>
    		</tr>
    	</tbody>
    </table>
    
  • click on the last cell, make sure that the whole cell is selected (in the elements path there should be "body table tbody tr td br" - note that probably the last "br" element is a problem here)
  • click on the "Table properties" item in the context menu
  • result: values in dialog are not properly loaded, when "Ok" is pressed, a new table is inserted.

Attachments

4948.patch (665 bytes) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 5 years ago by fredck

  • Milestone set to CKEditor 3.3

comment:2 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

Safari is the only browser that selected the entire cell when double click inside (not even Chrome), it has the following form of selection when last cell is selected:

<table>
<tr><td>[&nbsp;</td></tr></table>]

We should be able to transform the range into below to be recognized by table dialog.

<table>
<tr><td>[&nbsp;]</td></tr></table>

Changed 4 years ago by garry.yao

comment:3 Changed 4 years ago by garry.yao

  • Keywords Review? added

comment:4 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:5 Changed 4 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5490].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy