Ticket #4950 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Creating centered list is a bit troublesome

Reported by: wwalc Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Lists Version: 3.0
Keywords: Confirmed Review+ Cc: martinkou

Description

Tested and confirmed in IE8, FF 3.5, Safari 4.

Steps to reproduce

  • start with the following source:
    <ul>
    	<li>
    		aaa</li>
    	<li>
    		bbb</li>
    	<li>
    		ccc</li>
    </ul>
    
  • press Ctrl + A and hit "Center Justify" button
  • click at the end of last element and hit enter twice to exit from the list
  • result: list is not centered anymore.

this bug does not occur in FCKeditor.

Attachments

4950.patch (3.2 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by fredck

  • Milestone set to CKEditor 3.3

That's weird.

comment:2 Changed 5 years ago by garry.yao

Considering the facts that:

  1. Alignment style could only be applied on the list item;
  2. The list system destroys all list items style when transforming.

So it's not a surprise to have see this kind of result.

comment:3 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned
  • Component changed from General to Core : Lists

this bug does not occur in FCKeditor.

In v3, we're using an [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/enterkey/plugin.js#L85

innovative] way that uses outdent for 'exit enter'. Same bug happen in v2 if you replace the 3rd step in above TC with outdent command.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review? added
  • Cc martinkou added

Proposing an unobtrusive way to handle DOM nodes in arrayToList and listToArray, I pray that Martin could saw this patch and conduct the review ;)

comment:5 Changed 5 years ago by garry.yao

Ticket Test added:
run OR view source.

comment:6 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 4 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5285].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy