Some statements are comma separated
|Reported by:||alfonsoml||Owned by:|
Looking at the code in plugins/undo.js I've found two statements like
return this.restoreImage( image ), true;
That ", true" is useless as far as I understand and the lint check doesn't give a warning because it's disabled in its config:
-comma_separated_stmts # multiple statements separated by commas (use semicolons?)
Enabling that shows that there are other places where such problem exists. Some of them I guess that can be fixed by changing the comma to semicolon, but I don't know what's the logic for other situations like this one in tabletools:
if( trimCell( cell ), cell.getChildren().count() )
maybe it's a && there?
But as that can change the behavior each change should be done knowing what's the logic that should apply.
Change History (5)
comment:3 Changed 5 years ago by j.swiderski
- Resolution set to wontfix
- Status changed from new to closed