#5074 closed Bug (fixed)
Link target is not removed when changing to popup
| Reported by: | Frederico Caldeira Knabben | Owned by: | Martin |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.2 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | Cc: |
Description
- Load this HTML:
<p><a href="http://example.com" target="_self">Link</a></p>
- Open the link dialog for that think.
- In the "Target" tab, select the "<popup window>" option and give it a name like "MyPopup".
- Confirm the dialog and look at the source.
The previous "target" attribute will still be there. I should have been removed instead.
Attachments (2)
Change History (12)
comment:1 Changed 15 years ago by
| Milestone: | CKEditor 3.x |
|---|
comment:2 Changed 15 years ago by
| Owner: | set to Martin |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 15 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 15 years ago by
| Status: | review → review_failed |
|---|
The patch is OK, although coding style is wrong and there also unneeded change on L1254.
comment:5 Changed 15 years ago by
Additionally, the comments can be a bit more verbose and meaningful, like:
// Remove the "target" attribute. (#5074)
I know it's a bit too obvious, but gives a bit of sense to the ticket number.
Changed 15 years ago by
| Attachment: | 5074_2.patch added |
|---|
comment:6 Changed 15 years ago by
| Status: | review_failed → review |
|---|
Line 1254 is need bacuese without them in IE dialog working wrong.
comment:7 Changed 15 years ago by
| Status: | review → review_passed |
|---|
comment:8 Changed 15 years ago by
| Milestone: | → CKEditor 3.4.2 |
|---|
comment:9 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
fixed with revision [5929]
Note: See
TracTickets for help on using
tickets.
Milestone CKEditor 3.x deleted