Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#5099 closed Bug (fixed)

Smiley path configuration property not producing relative emiticon links

Reported by: JoeK Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: dchojna@…

Description

  1. Update you config.js to include config.smiley_path ='/plugins/sametimeemoticons/images/';
  2. Create an instance of the editor and insert a smiley.
  3. Click the Source button to enter HTML mode

Observe the the image src attribute values are not relative URLs.

Relative URLs were being used in version 3.0.1 when you set smiley_path.

Attachments (1)

5099.patch (1.0 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by JoeK

  • Milestone set to CKEditor 3.2

comment:2 Changed 6 years ago by alfonsoml

  • Keywords Pending WorksForMe added
  • Priority changed from High to Normal

I've tested Firefox 3.6, Chrome 4, IE 8 and Opera 10.10 and it's working fine in all of them.

comment:3 Changed 6 years ago by fredck

  • Milestone CKEditor 3.2 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

WFM also. Please feel free to reopen the ticket if you have more information about it.

comment:4 Changed 6 years ago by JoeK

  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Summary changed from Smiley path configuration property not producing relative emiticon links to CKEDITOR_BASEPATH has no affect on CKEDITOR.basePath.

I've investigated this further. Setting the global variable CKEDITOR_BASEPATH has no affect on CKEDITOR.basePath.

In this case smiley_path was set to CKEDITOR.basePath + '/plugins/smiley/images'.

comment:5 Changed 6 years ago by fredck

  • Keywords Confirmed added; Pending WorksForMe removed
  • Milestone set to CKEditor 3.3
  • Summary changed from CKEDITOR_BASEPATH has no affect on CKEDITOR.basePath. to Smiley path configuration property not producing relative emiticon links

Ok, I've opened a dedicated ticket for it to not make this one confusing.

In any case, we should use CKEDITOR.getUrl() in this configuration option, not CKEDITOR.basePath directly. I'm leaving this ticket opened so we can fix it.

Changed 5 years ago by garry.yao

comment:6 Changed 5 years ago by garry.yao

  • Keywords Review? added

comment:7 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from reopened to new

comment:8 Changed 5 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

comment:9 Changed 5 years ago by garry.yao

  • Status changed from new to assigned

Fixed with [5226].

comment:10 Changed 5 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:11 Changed 5 years ago by ivolucien

I'm getting this in 3.3.1, should I reopen this one or start a new ticket? I checked and the patch above had already been incorporated into _source/plugin/smiley/plugin.js

comment:12 Changed 5 years ago by fredck

Please open a new ticket with full details about the issue. Thanks.

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy