Opened 6 years ago

Closed 6 years ago

#5118 closed Bug (fixed)

Arrow keys navigation in RTL languages is incorrect

Reported by: Saare Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: Accessibility Version: 3.1
Keywords: Confirmed Review+ Cc:

Description

It is expected that the left arrow key will go to the icon that is to the left of the current, but in RTL languages the left arrow is actually mobing to the icon that is to the right of the current.
in other words, the navigation arrow keys should be switched when using RTL language.

Attachments (2)

5118.patch (1.6 KB) - added by garry.yao 6 years ago.
5118.2.patch (2.4 KB) - added by Saare 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by fredck

  • Keywords Confirmed added
  • Milestone set to CKEditor 3.3

comment:2 follow-up: Changed 6 years ago by Saare

Applies to the context menu as well.

comment:3 Changed 6 years ago by Saare

..and Smiley dialog.

Changed 6 years ago by garry.yao

comment:4 in reply to: ↑ 2 ; follow-up: Changed 6 years ago by garry.yao

  • Keywords Review? added
  • Owner set to garry.yao
  • Status changed from new to assigned

Replying to Saare:

Applies to the context menu as well.

In which sense? The sub menu keystrokes is correct for me in trunk.

comment:5 in reply to: ↑ 4 Changed 6 years ago by Saare

  • Keywords Review- added; Review? removed

Replying to garry.yao:

Replying to Saare:

Applies to the context menu as well.

In which sense? The sub menu keystrokes is correct for me in trunk.

I don't remember what was the problem with the context menu, so ignore it for now. i'll let you know if i encounter this bug again.
Anyway, R- because L14 in specialchar dialog should be like L10 in smiley dialog in the patch, and the bug ahould be fix in the editor toolbar as well.

Changed 6 years ago by Saare

comment:6 Changed 6 years ago by Saare

  • Keywords Review? added; Review- removed

comment:7 Changed 6 years ago by garry.yao

  • Keywords Review+ added; Review? removed
  • Resolution set to fixed
  • Status changed from assigned to closed

:) Thank you Saare, you're a wonderful JavaScript developer[[BR]] Fixed with [5235].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy