Opened 15 years ago
Closed 15 years ago
#5121 closed Bug (fixed)
Selecting line and changing Paragraph Format changes all lines in paragraph
| Reported by: | rgm | Owned by: | brooks |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | Core : Styles | Version: | SVN (CKEditor) - OLD |
| Keywords: | Review+ | Cc: | technology@… |
Description
The FCK editor allows you to only change the selected line with Paragraph Format, i.e. it recognizes the <br /> tag as a separator. This doesn't work in the CKEditor.
Firefox on Mac
- Type some text separated with a <br /> tag.
- Select a line and change the Paragraph Format.
- All lines change (not just the selected line).
Attachments (5)
Change History (18)
comment:1 Changed 15 years ago by
| Component: | General → Core : Styles |
|---|---|
| Keywords: | Confirmed added |
| Milestone: | → CKEditor 3.3 |
| Version: | 3.1 → SVN (CKEditor) |
comment:3 Changed 15 years ago by
| Owner: | set to brooks |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 5121.patch added |
|---|
comment:4 Changed 15 years ago by
| Keywords: | Review? added; Confirmed removed |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
CKEDITOR.config != editor.config
Changed 15 years ago by
| Attachment: | 5121_2.patch added |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The patch makes the CKEDITOR.style class dependent on the editor object, unnecessarily. It also makes the setEditor call mandatory when applying a block style, otherwise the applyBlockStyle function breaks.
What we could have instead is an *optional* property named "enterMode" in CKEDITOR.style class instances which defaults to CKEDITOR.ENTER_P if not defined.
Changed 15 years ago by
| Attachment: | 5121_3.patch added |
|---|
Changed 15 years ago by
| Attachment: | 5121_4.patch added |
|---|
comment:9 Changed 15 years ago by
please review both 5121_3.path and 5121_4.patch
IMO,5124_4.patch is better:-)
comment:10 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
5124_4.patch is the right way for it, besides, 'format' plugin should be included into the fix.
Changed 15 years ago by
| Attachment: | 5121_5.patch added |
|---|
comment:11 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:12 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:13 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
fixed with 5402 5402
Similar with #4046.