#5152 closed Bug (fixed)
Indentation using classes is buggy
Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Alfonso Martínez de Lizarrondo |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | Core : Styles | Version: | 3.3.1 |
Keywords: | Review+ | Cc: | Paweł Wilk |
Description
Seems that it's not possible to indent that way a third level, and removing the indent only works if there's a single level.
Tested with
indentClasses : ['Indent1', 'Indent2', 'Indent3'],
and
.Indent1 { margin-left: 40px; } .Indent2 { margin-left: 80px; } .Indent3 { margin-left: 120px; }
Attachments (1)
Change History (8)
Changed 15 years ago by
Attachment: | 5152.patch added |
---|
comment:1 Changed 15 years ago by
Keywords: | Review? added |
---|---|
Owner: | set to Alfonso Martínez de Lizarrondo |
Status: | new → assigned |
comment:2 Changed 15 years ago by
Milestone: | → CKEditor 3.3 |
---|
comment:4 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:5 follow-up: 6 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [5211]
comment:6 Changed 14 years ago by
Version: | 3.1 → 3.3.1 |
---|
Replying to alfonsoml:
Fixed with [5211]
Hi,
In version 3.3.1 [5548] the indentation using classes bug "came back".
The code proposed by alfonsoml:
block.$.className = CKEDITOR.tools.ltrim( className + ' ' + editor.config.indentClasses[ indentStep - 1 ] );
was replaced with the buggy code:
element.addClass( editor.config.indentClasses[ indentStep - 1 ] );
Using the alfonso's patch works well:
element.$.className = CKEDITOR.tools.ltrim( className + ' ' + editor.config.indentClasses[ indentStep - 1 ] );
The bug also exists in 3.3.2 and 3.4 beta
comment:7 Changed 14 years ago by
@jorgeoa, please open a new ticket for it as this one is already closed.
Proposed patch