#5189 closed Bug (fixed)
Find/Replace dialog: rename button to "Close"
| Reported by: | Frederico Caldeira Knabben | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1.3 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | Discussion | Cc: | mattleff@… |
Description
In the Find/Replace dialog, the button should be labeled "Close" and not "Cancel", because it doesn't really cancels the replacement operation.
Change History (10)
comment:1 Changed 14 years ago by
| Milestone: | CKEditor 3.x |
|---|
comment:2 Changed 12 years ago by
| Cc: | mattleff@… added |
|---|
@fredck My team has noticed this inconsistency as well. Could we get this targeted for CKEditor 4?
comment:3 Changed 12 years ago by
I've added a pull request for this: https://github.com/ckeditor/ckeditor-dev/pull/28.
comment:4 Changed 12 years ago by
| Status: | new → confirmed |
|---|
comment:5 Changed 11 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 11 years ago by
| Milestone: | → CKEditor 4.1.3 |
|---|
comment:7 Changed 11 years ago by
| Status: | assigned → review |
|---|
Pulled and modified. There is one unit test for this.
comment:8 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Here you go:
- Rebased both branches on latest master.
- Fixed code style both in t/5189 and tests.
- Discarded ambiguous button label test. This is a really minor change and doesn't need to be covered by tests. Additionally tests shouldn't depend on any particular translation or lang file.
Please don't forget about proper change log entry masterizing the branch.
comment:9 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Note: See
TracTickets for help on using
tickets.
Milestone CKEditor 3.x deleted