Ticket #5224 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

The Toolbar has been Frozen, textarea uneditable

Reported by: realvalkyrie Owned by: fredck
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed IE? Cc:

Description

the code as follows:

<B><FONT face=Tahoma size=2><SPAN style="FONT-WEIGHT: bold; FONT-SIZE: 10pt; FONT-FAMILY: Tahoma">De:</SPAN></FONT></B><FONT size=2><SPAN style="FONT-SIZE: 10pt; FONT-FAMILY: Tahoma"> Devz <BR><B><SPAN style="FONT-WEIGHT: bold">Enviado el:</SPAN></B> MartZ<BR><B><SPAN style="FONT-WEIGHT: bold">Para:</SPAN></B> Mary Lua<BR><B><SPAN style="FONT-WEIGHT: bold">Asunto:</SPAN></B> RV: Documents</SPAN></FONT><FONTFACE="MS PGothic?><BR>Dear Devito,</SPAN></FONT><FONT face="Times New Roman" size=3><SPAN style="FONT-SIZE: 12pt"><BR>ADSDF</SPAN></FONT>

Attachments

5244.patch (583 bytes) - added by garry.yao 4 years ago.
5224_2.patch (564 bytes) - added by fredck 4 years ago.

Change History

comment:1 Changed 5 years ago by realvalkyrie

if replace the invalid html tag "FONTFACE" to "FONT FACE" it's work perfect

comment:2 Changed 5 years ago by fredck

  • Keywords Confirmed IE added; Frozen,Uneditable removed
  • Milestone changed from CKEditor 3.x to CKEditor 3.3

Confirmed in IE only. Works well with FF.

Simply paste the provided HTML in the source view and move back to wysiwyg. The toolbar gets stuck, as well as the editor editing.

comment:3 Changed 5 years ago by m.nguyen

if replace the invalid html tag "FONTFACE" to "FONT FACE" it's work perfect

We haven't FONTFACE tag, we have a FONT tag and FACE attribute. http://www.w3.org/TR/html4/index/elements.html

Works well with FF

In this case, FF (Safari, Chrome) ignore invalid tags. You can try "XYZ" tag or "Nguyen" tag it still display well.

comment:4 Changed 5 years ago by realvalkyrie

fredck's description is exactly right。 3Q 4 All reply

comment:5 Changed 5 years ago by Saare

The line 'window.parent.CKEDITOR._contentDomReadyeditor1?( window ); ' is also appended.
I found out it happens because of the unclosed tag produced, and not because of an invalid tag.
'<FONTFACE="MS PGothic?>' - instead of quote mark there is a question mark, which breaks the HTML. here's an example:

<FONTFACE="MS PGothic?><FONT face="Times New Roman" size=3>"ADSDF

the parser is parsing it as:

<FONTFACE="
MS PGothic?><FONT face=
"
Times New Roman"
 size=3>
"
ADSDF

so it looks like an unclosed tag.

Changed 4 years ago by garry.yao

comment:6 Changed 4 years ago by garry.yao

  • Status changed from new to assigned
  • Owner set to garry.yao
  • Keywords Review? added

comment:7 Changed 4 years ago by Saare

With this patch, paste the following into source:

<FONTFACE="MS PGothic?><FONT face="Times New Roman" size=3>"ADSDF

Switch to WYSIWYG mode. there is no content in the editor.
Switch back to Source mode. there is a code inside.
Switch again to WYSIWYG mode. now there is a content in the editor.

comment:8 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

I'm not going on a detailed review for now, but the patch looks plain wrong. Deferring.

comment:9 Changed 4 years ago by fredck

  • Owner changed from garry.yao to fredck
  • Keywords Review- added; Review? removed
  • Status changed from assigned to new

I've just spent 2 hours on reviewing and research on this issue. We must make it in a way that the invalid tag will be simply ignored, instead of trying to use it somehow... of course, without affecting performance.

I'll be proposing something.

Changed 4 years ago by fredck

comment:10 Changed 4 years ago by fredck

  • Keywords Review? added; Review- removed

While testing this patch, I haven't noticed any performance impact.

comment:11 Changed 4 years ago by fredck

  • Status changed from new to assigned

comment:12 Changed 4 years ago by fredck

  • Status changed from assigned to review

comment:13 Changed 4 years ago by Saare

  • Status changed from review to review_passed

comment:14 Changed 4 years ago by fredck

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5740].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy