Opened 6 years ago

Closed 6 years ago

#5261 closed Bug (fixed)

scayt_autoStartup slow down editor loading

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: SVN (CKEditor) - OLD
Keywords: Firefox Confirmed Review+ Cc: SpellChecker.net

Description

Loading SCAYT on startup could somehow compromise all the efforts we've done to accelerate loading performance, where the SCAYT engine file (~100K) is blocking our theme file in execution order, which in turn made the editor loading significant slower (6x) than it should.
This could at least be confirmed on Firefox and Opera where DOM script loading is sequence sensitive.

Attachments (1)

5261.patch (489 bytes) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by garry.yao

comment:1 Changed 6 years ago by garry.yao

  • Keywords HasPatch added

Could SpellChecker.net evaluate if this simple fix is OK or could otherwise compromise SCAYT?

comment:2 follow-up: Changed 6 years ago by SpellChecker.net

This fix is Ok in spite of makes the SCAYT a little bit slowly.

comment:3 in reply to: ↑ 2 Changed 6 years ago by garry.yao

Replying to SpellChecker.net:

This fix is Ok in spite of makes the SCAYT a little bit slowly.

Well, considering the availability of SCAYT is based on the editor instance, I highly recommend taking editor loading time into SCAYT performance consideration.

comment:4 Changed 6 years ago by SpellChecker.net

While we review ways to improve the SCAYT load performance we see that the solution proposed can be used to improve editor performance without affecting SCAYT functionality.

comment:5 Changed 6 years ago by garry.yao

  • Keywords Confirmed Review? added; HasPatch removed
  • Owner set to garry.yao
  • Status changed from new to assigned

comment:6 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5328].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy