Preview in font-size and font-family doesn't work with custom styles

[Alfonso Martínez de Lizarrondo]

Using the XHTML sample in #5024, the previews of font-size and font-family doesn't reflect the current values.

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Garry Yao]

The problem is we've already had ​such implementation. It would be better to introduce a 'buildlPreviewHtml' method on CKEDITOR.style that encapsulate those logics to be used by all places, including fonts, format and styles.

[Alfonso Martínez de Lizarrondo]

I thought about it but there's a problem with CKEDITOR.style::getStyleText because it will try to normalize the css style and it chokes when it finds a value like font-family:#(family)

The option that I see would be to put pass to that CKEDITOR.style.buildPreviewHtml the styleDefinition as well as the cssStyle to use, and in the font plugin specify a placeholder like #(name) for the styleDefinition name and replace it in the loop.

Now that I think about it my original patch used a regExp for the value, but a simple string replacement would have been enough.

So: Do I create such CKEDITOR.style.buildPreviewHtml( styleDefinition, cssStyle ) function?

[Garry Yao]

it chokes when it finds a value like font-family:#(family).

True, the original implementation doesn't consider variables in style (it operate on style definition), while if an method is introduced, it operates naturally on compiled style object so such problem will vanish.

[Alfonso Martínez de Lizarrondo]

Revised patch

[Alfonso Martínez de Lizarrondo]

This was much easier that I thought.

[Alfonso Martínez de Lizarrondo]

Fixed with [5312]