Opened 6 years ago

Closed 6 years ago

#5352 closed Bug (fixed)

CKEDITOR.stylesSet.add can't be used inline with _source files

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: 3.2
Keywords: Review+ Cc:

Description

Trying to use the CKEDITOR.stylesSet.add in the page to define a stylesSet without using an external file doesn't work while using the _source files.

Attachments (2)

5352.patch (2.7 KB) - added by alfonsoml 6 years ago.
Proposed patch
5352_2.patch (2.3 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by alfonsoml

The solution could be to allow to define the stylesSet directly in the config object as suggested in http://dev.fckeditor.net/ticket/5024#comment:9

Changed 6 years ago by alfonsoml

Proposed patch

comment:2 Changed 6 years ago by alfonsoml

  • Keywords Review? added
  • Milestone set to CKEditor 3.3

After #5290 this is easy.

comment:3 Changed 6 years ago by alfonsoml

  • Owner set to alfonsoml
  • Status changed from new to assigned

Changed 6 years ago by garry.yao

comment:4 Changed 6 years ago by garry.yao

  • Keywords Review- added; Review? removed

The inline definition in config must be also available to 'CKEDITOR.stylesSet' and let's make this config as documentation-only.

comment:5 Changed 6 years ago by garry.yao

  • Keywords Review+ added; Review- removed

After a discussion with Alfonso, the above patch may cause problem when multiple instances are using the inline way to define styles, so it's safe to leave it the original way.

comment:6 Changed 6 years ago by alfonsoml

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5288]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy