Ticket #5356 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Scayt options dialog doesn't work with prototype.js enabled environments

Reported by: antti.leppa Owned by:
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: 3.2
Keywords: Confirmed HasPatch Cc: SpellChecker.net

Description

When using CKEditor in prototype.js enabled environments SCAYT plugin options dialog opening crashes.

This is caused by plugins/scayt/dialogs/options.js:218

for ( i in buttons )

Normally this clause iterates over all items within a array but in prototype enabled environments this causes loop to iterate also over all extended methods thus causing following doc.getById( button) to fail

This problem can be fixed by changing line 218 into:

for ( i = 0; i < buttons.length; i++ )

The problem was discovered with Prototype 1.6.1

Change History

comment:1 Changed 4 years ago by alfonsoml

  • Keywords Confirmed added
  • Milestone set to CKEditor 3.3

comment:2 Changed 4 years ago by alfonsoml

  • Keywords HasPatch added

comment:3 Changed 4 years ago by fredck

  • Cc SpellChecker.net added

comment:4 Changed 4 years ago by fredck

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [5322].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy