Ticket #5415 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Undo not working when we change the Table Properties for the table on a saved page

Reported by: satya Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4
Component: Core : Undo & Redo Version: 3.0
Keywords: IBM Confirmed Review+ Cc: joek,damo

Description

To reproduce the defect

  1. Open Ajax sample.
  1. Insert a Table and enter the text in Table Cells.
  1. Click on Remove Editor button to save the Page.
  1. Click on Create Editor button to open the page again.
  1. Go in to one of Table cells and Open Table Context menu and Click on Table Properties.
  1. In Table Properties dialog change Table Alignment to Center and Click OK.

Expected Result

Table is Aligned to Center and the Undo button should be enabled.

Actual Result

Table is Aligned to the Center but the Undo button is not enabled and it will not enable even if we change any number of Table Properties.It is only enabled when we type some text in the Editor.

Attachments

5415.patch (1.2 KB) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

Changed 4 years ago by garry.yao

comment:2 Changed 4 years ago by garry.yao

  • Status changed from new to assigned
  • Keywords Confirmed Review? added
  • Version changed from 3.2 to 3.0
  • Component changed from General to Core : Undo/Redo
  • Owner set to garry.yao

We have similar issues in other dialogs, e.g. insert Link, it's not bad to take a bit automation here.

comment:3 Changed 4 years ago by tobiasz.cudnik

  • Keywords Review+ added; Review? removed

This is a good solution which resolves other issues like #5846.

We may additionally remove some savesnapshot events in other dialogs, which will be unnecessary after this fix.

comment:4 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5669].

comment:5 Changed 4 years ago by tobiasz.cudnik

Committed into correct branch with [5693].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy