Press enter on 'replace' button result wrong

[Garry Yao]

Reproducing Procedures

1. Load the any of the sample page;
2. Open 'Replace' dialog and fill in 'are';
3. Tab to focus the 'Replace All' button and press 'Enter';

• Expected Result: You get only the success message.
• Actual Result: You get both message: 'Specified text not found' and '1 occurance replaced'.

[brooks]

this bug only happen in firefox, it's a weired behavior

when debugger, e.g, add break point in source code, u can't reproduce the bug

I trace to here:
_source/plugins/dialogui/plugin.js#503

element.on( 'click', function( evt )
{   console.log( 'click fired!' );
	me.fire( 'click', { dialog : me.getDialog() } );
	evt.data.preventDefault();
} );

element.on( 'keydown', function( evt )
{
	if ( evt.data.getKeystroke() in { 32:1, 13:1 } )
	{	console.log( 'keydown fired!' );
		me.click();
		evt.data.preventDefault();
	}
} );

then found when hit enter,the click event fired too.

[Garry Yao]

this bug only happen in firefox, it's a weired behavior

It's indeed a Firefox bug, I believe the default event behavior is somehow affected by the focus (alert box grab the focus from button). While the real problem is that the [​http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/dialogui/plugin.js#L507

click simulating logics] are not needed at all, since most major browsers and assistive technologies trigger onClick if the Enter key is pressed when the link has focus.

[brooks]

yes, in firefox, when a link is focused and then hit enter key, it will fire click event and couldn't be prevent.

[Garry Yao]

It's not a FF only behavior, actual all browsers agree with it on link, and our buttons are all made of ​link, so IMO we just need to remove the enterkey delegation in all places:

if ( evt.data.getKeystroke() in { 32:1 } )

[brooks]

the FF only behavior is that when a link is focused,the enterkey delegation couldn't be prevented,but other browsers could.

of course,it's a nice idea not to listen the keydown event for enter key in this case, 'cause the click event will always fired when hit a focused link.

[Garry Yao]

Please remove the extra spaces on committing.

[brooks]

fixed with 5402 5402