Ticket #5462 (closed Bug: expired)

Opened 5 years ago

Last modified 5 years ago

Color is removed improperly from partial selections

Reported by: fredck Owned by: fredck
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

  1. Open the replacebyclass sample.
  1. Hit CTRL+A to select all text.
  1. Apply a background color (e.g. yellow).
  1. Select "some sample".
  1. Apply a different background color (e.g. green).

The yellow background from the " text" bold text will be removed, remaining transparent.

Confirmed with FF 3.6 at least. Works well with the 3.2.

Attachments

5462.patch (1.6 KB) - added by garry.yao 5 years ago.
5462_2.patch (2.2 KB) - added by fredck 5 years ago.

Change History

comment:1 Changed 5 years ago by fredck

As expected, the same happens with the foreground color.

comment:2 Changed 5 years ago by garry.yao

  • Keywords Firefox Safari added

Works in IE only.

Changed 5 years ago by garry.yao

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review? added; Firefox Safari removed
  • Status changed from new to assigned
  • Owner set to garry.yao

Oops, affects IE also.
Regression of [5251].

comment:4 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed
  • Owner changed from garry.yao to fredck
  • Status changed from assigned to new

The change makes sense, even if it still doesn't fix the partial override issue, which must not be handled by this ticket anyway.

I'll be providing a simplified patch.

Changed 5 years ago by fredck

comment:5 Changed 5 years ago by fredck

  • Status changed from new to assigned
  • Keywords Review? added; Review- removed

comment:6 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:7 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5343].

comment:8 Changed 5 years ago by garry.yao

  • Status changed from closed to reopened
  • Resolution fixed deleted

Due to the risky explained here, this fix is reverted by [5347] and the ticket is expired.

comment:9 Changed 5 years ago by garry.yao

  • Status changed from reopened to closed
  • Resolution set to expired
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy