Ticket #5487 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Fullpage writer problem with line-break

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version:
Keywords: Cc:

Description (last modified by garry.yao) (diff)

Environment

All IE versions.

Reproducing Procedures

  1. Load the 'Full Page Support' sample page;
  2. Press 'Enter' key at the end of the first paragraph to create a new empty line;
  3. Switch to source mode:
  • Actual Result:
    <html>
    	<head>
    		<title>CKEditor Sample</title>
    	</head>
    	<body>
    		<p>
    			...</p></body>
    </html>
    
  • Expected Result: There's a line break before closing </body>
    <html>
    	<head>
    		<title>CKEditor Sample</title>
    	</head>
    	<body>
    		<p>
    			...</p>
           </body>
    </html>
    

Attachments

5487.patch (1.2 KB) - added by garry.yao 5 years ago.
5487_2.patch (670 bytes) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Description modified (diff)

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

  • Status changed from new to assigned
  • Owner set to garry.yao
  • Keywords Confirmed Review? added
  • Milestone set to CKEditor 3.4

comment:3 Changed 4 years ago by fredck

  • Keywords Review- added; Review? removed

There is no need to match the space group. It can be simply added to the (?=) lookahead assertion at the end of the regex.

Changed 4 years ago by garry.yao

comment:4 Changed 4 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:5 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.4 to CKEditor 3.5

comment:6 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review to review_passed

comment:7 Changed 4 years ago by tobiasz.cudnik

  • Status changed from review_passed to closed
  • Keywords Confirmed removed
  • Resolution set to fixed

Fixed with [5859].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy