All IDs and classes should all have the 'cke_' prefix

[Sa'ar Zac Elias]

While I was reading the code I've noticed that not all IDs (e.g. in dialogs) and classes (e.g. in the colordialog plugin) uses the 'cke_' prefix, some of them are quite common IDs such as 'picker'. This can lead to collision and make the integration problematic.

[Sa'ar Zac Elias]

Has a relation with #5138, so maybe both bugs will be handled in one patch.
Maybe a generic function should be created to get IDs with the 'cke_' prefix and at the same time get the IDs in the same convention (e.g. all letters lowercase or capitalize).

[Sa'ar Zac Elias]

Another thing that should be changed, the dialog UI generates IDs like '91_uiElement'.

[Alfonso Martínez de Lizarrondo]

#5324 has been marked as dup

[Sa'ar Zac Elias]

The second patch covers also the smiley and color dialogs.

[Frederico Caldeira Knabben]

• I still can see several improper ids in the dialogs.

• We can see that most of the ids are build with the same formula: 'cke_' + CKEDITOR.tools.getNextNumber(). It makes sense introducing a new CKEDITOR.tools.getNextId() function which makes the code simpler, shorter, and guarantees the results are uniform.

Also, just to be sure, let's target it to the 3.4.x branch.

[Sa'ar Zac Elias]

I used a tool script to list all elements without the 'cke_' prefix this time.

[Frederico Caldeira Knabben]

That's cool :)

Later we can also consider removing all those suffixes, as they don't bring anything useful, other than making the code bigger.

[Sa'ar Zac Elias]

Fixed with [5758].