Ticket #5565 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Erratic scrollbar behavior when opening a rich combo with RTL

Reported by: Saare Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Oracle Cc: Senthil, Pranav

Description

Open a rich combo in an RTL page. Notice that an horizontal scrollbar appears for a short time.
Tested on IE8 and FF3.6.6 with the current trunk. Looks like a regression.

Attachments

5565.patch (1.5 KB) - added by garry.yao 4 years ago.
5565_2.patch (688 bytes) - added by garry.yao 4 years ago.
5565_3.patch (1.7 KB) - added by Saare 4 years ago.

Change History

comment:1 Changed 4 years ago by garry.yao

  • Keywords Pending added
  • Milestone CKEditor 3.3 deleted

Works well for me on trunk.

comment:2 Changed 4 years ago by Saare

I can still reproduce it on trunk, but in FF it only happens in the second time or after.
Just notice that I was talking about an RTL page (with <html dir="rtl">), not the direction config.

Changed 4 years ago by garry.yao

comment:3 Changed 4 years ago by garry.yao

  • Status changed from new to assigned
  • Keywords Confirmed Review? added; Pending removed
  • Owner set to garry.yao
  • Milestone set to CKEditor 3.4

Notice that an horizontal scrollbar appears for a short time.

Just to clarify, scrollbar of the host page.

comment:4 Changed 4 years ago by fredck

  • Keywords Review- added; Review? removed

There are too many unrelated changes in the patch, one of them being even wrong. Just to clarify, the "opacity >= 100" check will never be true now. Let's keep it simple, and make only the necessary changes here.

Changed 4 years ago by garry.yao

comment:5 Changed 4 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:6 Changed 4 years ago by fredck

  • Cc Senthil, Pranav added
  • Keywords Oracle added

#5906 has been marked as DUP.

comment:7 Changed 4 years ago by Senthil

After applying the patch, combos are not working but when i only comment the following lines
left : '-3000px',
opacity : '0', FF3 is ignoring "visibility"

and removing the "element.setOpacity( 0 );" line then the reported problem is getting resolved. Can you please check ?

Changed 4 years ago by Saare

comment:8 Changed 4 years ago by Saare

  • Owner changed from garry.yao to Saare
  • Status changed from assigned to new

I'm having a different approach this time, after all my tests have failed. Instead of hiding the panel by pushing it to the side, I'm pusing it to the top. I've also added some coding style fixes.

comment:9 Changed 4 years ago by Saare

  • Status changed from new to assigned

comment:10 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:11 Changed 4 years ago by Saare

Fixed with [5686].

comment:12 Changed 4 years ago by Saare

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy