Opened 16 years ago
Closed 16 years ago
#5578 closed Bug (fixed)
Flash with Alignment is not shown properly in Editor body
| Reported by: | Satya Minnekanti | Owned by: | brooks |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | General | Version: | 3.2 |
| Keywords: | IBM Confirmed Review+ | Cc: | Damian, joek |
Description
To reproduce the defect:
- Open Ajax sample.
- Type some text and insert flash with right alignment.
- See that flash is inserted in the body of the editor and is shown as aligned to right.
- Type some more text and Click on Remove Editor button to save the page.
- See that Flash is shown with proper Alignment on Page View.
- Click on Create Editor button to open the page and see the Alignment of Flash in the boy of the Editor.
Expected Result:
Flash will be shown on the right hand side of Editor since it's Alignment was set to Right
Actual Result:
Flash is shown with out any Alignment and it is shown in the middle of the text when i check the Flash Alignment in Flash Properties it is showing Alignment correctly as Right
Attachments (3)
Change History (14)
comment:1 Changed 16 years ago by
| Keywords: | Confirmed added |
|---|---|
| Owner: | set to brooks |
| Status: | new → assigned |
Changed 16 years ago by
| Attachment: | 5578.patch added |
|---|
comment:2 Changed 16 years ago by
| Keywords: | review? added |
|---|
comment:3 Changed 16 years ago by
comment:4 Changed 16 years ago by
| Keywords: | review+ added; review? removed |
|---|
Ye, let's do that for safe.
comment:5 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
fixed with 5414 5414
comment:6 Changed 16 years ago by
| Keywords: | Review- added; review+ removed |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
Due to that checkin now it isn't possible to create a Page Break. In Firefox there's no error, but nothing happens, and in IE8 it throws an error pointing exactly at that line.
Changed 16 years ago by
| Attachment: | 5578_2.patch added |
|---|
comment:7 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
yes,add align property in
http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/fakeobjects/plugin.js#L67[[BR]]
will make page break down.recover it now
comment:8 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
We benefit with the change that fake element will automatically present alignment of the real element, I believe the problem is with the line itself:
align : realElement.attributes.align || '' V.S. align : realElement.getAttribute( 'align' )|| ''
Changed 16 years ago by
| Attachment: | 5578_3.patch added |
|---|
comment:10 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
There's no changelog needed.
comment:11 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
fixed with 5426 5426

is it need to add 'align' property at http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/fakeobjects/plugin.js#L67
?