Ticket #5580 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Maximize does not work properly in the Office 2003 and V2 skins

Reported by: Saare Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Toolbar Version: 3.0.1
Keywords: Confirmed HasPatch Review+ Cc: comp615@…

Description

Steps to reproduce

  • Go to the skins demo or the skins sample page.
  • Click on the Maximize button on the editors with the Office 2003 and V2 skins.

Notice that there is a space at the bottom and you can see other editor's toolbar buttons.
Tested with IE 8 and FF 3.6.3.

Attachments

5580.patch (914 bytes) - added by comp615 4 years ago.
Altered maximiser plugin to add the maximised class before calling the resize handler. See comments for more

Change History

comment:1 Changed 4 years ago by garry.yao

  • Keywords Confirmed added
  • Component changed from UI : Skins to UI : Toolbar
  • Milestone changed from CKEditor 3.3 to CKEditor 3.4

comment:2 Changed 4 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Owner set to tobiasz.cudnik

Changed 4 years ago by comp615

Altered maximiser plugin to add the maximised class before calling the resize handler. See comments for more

comment:3 Changed 4 years ago by comp615

  • Keywords HasPatch Review? added
  • Cc comp615@… added

Fixed the plugin to add the CSS attribute maximized BEFORE calling the rezize handler, since changing CSS properties (namely hiding the resize grip) can potentially alter the size of the header/footer areas, meaning the text editor would not be made large enough.

This bug would also cause any skin which has a different maximized header or footer size from normal to be displayed improperly.

comment:4 Changed 4 years ago by tobiasz.cudnik

Thank you for the patch, we will review it as soon as possible.

comment:5 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed

@comp615, it's a nice catch ;) It fixes the problem and doesn't bring any risk with the change.

I was not able to apply the patch directly. I did it manually instead. Please be sure to create patches from the root of our SVN trunk, with updated local copies.

comment:6 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5675].

comment:7 Changed 4 years ago by tobiasz.cudnik

Committed into correct branch with [5699].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy