Opened 6 years ago

Closed 6 years ago

#5582 closed Bug (fixed)

Closing dialog boxes causes warning in IE

Reported by: jfvaren Owned by: brooks
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Dialogs Version: 3.2.1
Keywords: confirm Review+ Cc:

Description

When clicking the top right close link (the red "X") in any dialog box (insert image, spell-checker, etc), Internet Explorer interprets the action as navigating to another page due to the presence of the href attribute in the link element. This does not happen if the user closes the popup using the bottom right "Cancel" button.

Because we monitor changes made to the content, warning the user about the potential loss of data should the user choose to navigate away from the current page, this warning is triggered when the user closes a dialog box using the top right close link.

A fairly easy fix for this problem is to add an onclick="return false;" to the link element.

Attachments (1)

5582.patch (448 bytes) - added by brooks 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by brooks

  • Owner set to brooks
  • Status changed from new to assigned

when I click 'x' in IE6, I heard the 'dida' sound,but this not happen the cancel button

Changed 6 years ago by brooks

comment:2 Changed 6 years ago by brooks

  • Keywords Review? added; Dialog IE Internet Explorer removed

comment:3 Changed 6 years ago by garry.yao

  • Component changed from General to UI : Dialogs
  • Keywords Review+ added; Review? removed

comment:4 Changed 6 years ago by brooks

  • Keywords confirm added
  • Resolution set to fixed
  • Status changed from assigned to closed

fixed with 5408 5408

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy