Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5649 closed Bug (fixed)

Image dialog too wide when many styles are set

Reported by: wwalc Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version: 3.1
Keywords: Oracle IE Cc: senthil.kumaran@…

Description

After setting various properties, like border, hspace, vspace etc. and switching to the advanced tab in IE7, the dialog expands too much (see screenshot).

Confirmed in IE6 and IE7.

Attachments (5)

ckeditor_ie7_image_dialog_advanced_properties_r5444.png (33.1 KB) - added by wwalc 6 years ago.
5649.patch (2.2 KB) - added by brooks 6 years ago.
5649_2.patch (2.3 KB) - added by tobiasz.cudnik 6 years ago.
replacebycode.html (2.1 KB) - added by Senthil 6 years ago.
C:\Documents and Settings\SKumaran\Desktop\ckeditor_3.4\ckeditor\_samples
dialog issue.PNG (34.3 KB) - added by Senthil 6 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 6 years ago by brooks

  • Owner set to brooks
  • Status changed from new to assigned

Changed 6 years ago by brooks

comment:2 Changed 6 years ago by brooks

  • Keywords review? added

where,after try much times to fix it with only CSS rules change, I failed. so comes this heavyweight workaround.

comment:3 Changed 6 years ago by garry.yao

  • Keywords Review- added; review? removed

The idea is ok, while we must limit the fix to only affected browsers, and check whether some undesired 'onchange' event is get triggered by that, besides, DOM changes should be handled by 'element::setCustomData'.

comment:4 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.4 to CKEditor 3.5

comment:5 Changed 6 years ago by tobiasz.cudnik

  • Owner changed from brooks to tobiasz.cudnik
  • Status changed from review_failed to assigned

I'm taking this one over Brooks.

Changed 6 years ago by tobiasz.cudnik

comment:6 Changed 6 years ago by tobiasz.cudnik

  • Status changed from assigned to review

It doesn't trigger any onChange events as there is no dialog API usage.

comment:7 Changed 6 years ago by Saare

  • Keywords Confirmed removed
  • Status changed from review to review_passed

comment:8 Changed 6 years ago by tobiasz.cudnik

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5844].

comment:9 Changed 6 years ago by Senthil

I am still seeing this problem in the nightly build, please test it using the attached sample file. In this sample file, double click on the "CKEditor" link(Editor Area). This will open up the link dialog and select the advanced tab and see the issue(screen shot is attached).

Changed 6 years ago by Senthil

C:\Documents and Settings\SKumaran\Desktop\ckeditor_3.4\ckeditor\_samples

Changed 6 years ago by Senthil

comment:10 Changed 6 years ago by Senthil

  • Cc senthil.kumaran@… added
  • Keywords Oracle added

comment:11 Changed 6 years ago by Senthil

Saare, any update on this?

comment:12 Changed 6 years ago by Senthil

  • Keywords IE removed

comment:13 Changed 6 years ago by Saare

  • Keywords IE added

WFM on trunk.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy