Ticket #5651 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Wrong button label apostrophe escaping

Reported by: Jangaroo Owned by: Saare
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Dialogs Version:
Keywords: Confirmed Review+ Cc:

Description

  • Descriptive summary : Apostrophes in button labels are replaced by "undefined" instead of empty string
  • Steps to reproduce : Found the bug by code-reading. I guess the effect of the bug should be as follows: Define a button with a label containing an apostrophe ("Bill's Button"). Open CKEditor with such a button in Firefox (version >= 10900). Hover over the button. The status bar reads: "void('Billundefineds Button')".
  • Browser name and OS : Firefox (version >= 10900).
  • Code Patch:

Replace '+' by ',' in button's plugin.js, line 137: svn\CKEditor\trunk\_source\plugins\button\plugin.js (revision 5259):

@@ -134,7 +134,7 @@

'<span class="cke_button">', '<a id="', id, '"' +

' class="', classes, '"',

env.gecko && env.version >= 10900 && !env.hc ? : '" href="javascript:void(\+ ( this.title + env.gecko && env.version >= 10900 && !env.hc ? : '" href="javascript:void(\+ ( this.title
).replace( "'"+ )+ '\')"',
).replace( "'", )+ '\')"',

' title="', this.title, '"' + ' tabindex="-1"' + ' hidefocus="true"' +

Attachments

5651.patch (695 bytes) - added by Saare 4 years ago.

Change History

comment:1 Changed 4 years ago by alfonsoml

  • Milestone set to CKEditor 3.4

Changed 4 years ago by Saare

comment:2 Changed 4 years ago by Saare

  • Keywords Confirmed Review? added
  • Status changed from new to assigned
  • Owner set to Saare

Thanks @Jangaroo.

comment:3 Changed 4 years ago by fredck

  • Keywords Review+ added; Review? removed
  • Component changed from General to UI : Dialogs

comment:4 Changed 4 years ago by Saare

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5702].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy